Adding ability to define testing space through convex hull #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS ALMOST READY, STILL NEEDS TO BE CLEANED UP
This PR adds two things:
We introduce the ability to define all of the training points as a list. The testing points are then defined to be points in the convex hull of the training points. This is useful if we are not interested in sampling for a rectangular grid, and have a specific region of interest for the problem. The post-processing files need to be changed and I still need to add them.
We now track the training loss and each term of the loss function. These losses are saved with the final output file after training.