Move primal::NumericArray to core
#1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunney1
requested review from
BradWhitlock,
kennyweiss,
rhornung67,
nselliott,
bmhan12 and
Arlie-Capps
BradWhitlock
reviewed
Feb 4, 2025
BradWhitlock
reviewed
Feb 4, 2025
kennyweiss
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks @gunney1 -- seems like a reasonable change.
NumericArray is more of a (linear) algebra support class and does not include any geometry, although it contains the core functionality for primal::Point and primal::Vector.
Required changes:
- It looks like the core_numeric_array unit tests are commented out. I'd be happy to approve once those are added back in.
- I agree w/ @BradWhitlock that
NumericArrayshould be in the same directory as the other array classes
Clarification:
Also, I'm a bit confused about this line in the PR description:
It has general utilities like supporting multidimensional index arithmetic.
since I don't think it directly contains any functionality for multidimensional indexing. Am I missing something, or did you mean that it can be used to help w/ multidimensional indexing? If so, do we have any existing examples?
BradWhitlock
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
primal::NumericalArrayclass tocoreThe motivation for this:
NumericalArraydoesn't depend onprimalwhere it had lived.This PR implements issue #1488.