Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spack v1.0 support: %foo +bar -> +bar %foo #1522

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

haampie
Copy link

@haampie haampie commented Mar 17, 2025

Spack v1.0 will parse pkg %gcc +foo as "pkg with direct dependency gcc
with variant foo enabled" instead of "pkg with variant foo enabled and compiler
gcc". Reorder as pkg +foo %gcc to be compatible with Spack v0.x and
v1.0.

Summary

  • This PR is a (refactoring, bugfix, feature, something else)
  • It does the following (modify list as needed):
    • Modifies/refactors (class or method) (how?)
    • Fixes (issue number(s))
    • Adds (specific feature) at the request of (project or person)

Design review (for API changes or additions---delete if unneeded)

On (date), we reviewed this PR. We discussed the design ideas:

  1. First idea or goal
  2. Second idea
  3. Third idea

This PR implements 1. and 3. It leaves out 2. for the following reasons

  • (impractical)
  • (too big)
  • (not a good idea anyway)

Spack v1.0 will parse `pkg %gcc +foo` as "pkg with direct dependency gcc
with variant foo enabled" instead of "pkg with variant foo enabled and compiler
gcc". Reorder as `pkg +foo %gcc` to be compatible with Spack v0.x and
v1.0.
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haampie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants