Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack_build.yml to fix cmake pulling llvm #698

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Update spack_build.yml to fix cmake pulling llvm #698

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac20b3d
Update spack_build.yml to fix cmake pulling llvm
cameronrutherford Nov 6, 2024
4315931
Update spack_build.yml to specify cmake requirements for all packages…
cameronrutherford Nov 7, 2024
0c1e55f
Move openblas into direct package spec
cameronrutherford Nov 7, 2024
a486ada
Specify openblas in a different way
cameronrutherford Nov 7, 2024
7ba7b00
Try re-using builds for quicker pipelines
cameronrutherford Nov 7, 2024
d07cab2
Add some comments and move libevent version spec
cameronrutherford Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/spack_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ jobs:
strategy:
matrix:
spack_spec:
- hiop@develop+mpi~raja~shared~kron~sparse ^openblas ^openmpi ^libevent~openssl
- hiop@develop~mpi~raja~shared~kron~sparse ^openblas ^libevent~openssl
- hiop@develop~mpi+raja~shared~kron~sparse ^openblas ^libevent~openssl
- hiop@develop+mpi~raja~shared~kron~sparse ^openblas ^openmpi
- hiop@develop~mpi~raja~shared~kron~sparse ^openblas
- hiop@develop~mpi+raja~shared~kron~sparse ^openblas

# We will need coinhsl for this, but what are the rules for using
# a coinhsl tarball?
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
cat << EOF > spack.yaml
spack:
specs:
- ${{ matrix.spack_spec }} target=x86_64_v2
- ${{ matrix.spack_spec }} ^libevent~openssl target=x86_64_v2
concretizer:
reuse: dependencies
config:
Expand All @@ -141,10 +141,13 @@ jobs:
padded_length: False
mirrors:
local-buildcache: oci://${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
# spack: https://binaries.spack.io/develop
spack: https://binaries.spack.io/develop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a bad idea

packages:
all:
require: "%gcc"
# https://spack.readthedocs.io/en/latest/packages_yaml.html#setting-requirements-on-virtual-specs
cmake:
require: "~qtgui~ncurses"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cameronrutherford how did you figure out these parameters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was part of my initial debugging.

As we are using spack@develop, we are always getting the latest and "greatest" changes. In this case we inherited some changes to CMake that seemed to make it build these options when it wasn't previously.

This forces any build of CMake to have these options disabled.

See this job's concretization step for an example of what I mean. Compare that to a later passing pipeline here. Notice how the updated config results in a much smaller build.

Sure we could probably get the more complicated builds to work too, but a minimal build is faster, and less error prone - we shouldn't build things we don't need.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What pointed me to this was noticing the delta in the concretizations. I looked through the logs, noticed that we were having builds fail on a dependency we don't normally build, and then figured out what package was to blame. Then I worked with that package's spack build config to figure out what to enable / disable.

https://packages.spack.io is a great way to get this information quickly.

EOF

- name: Configure GHCR mirror
Expand Down
Loading