Fix dg_euler build #284
Merged
Fix dg_euler build #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-copeland
requested review from
ckendrick,
siuwuncheung,
dreamer2368 and
chldkdtn
ckendrick
approved these changes
Apr 26, 2024
|
We need 1 more approval to fix the broken libROM build. @chldkdtn @siuwuncheung @dreamer2368 |
siuwuncheung
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MFEM PR 3598 was recently merged to the MFEM
masterbranch, refactoring ex18(p). One change that causes build issues with libROM is thatclass RiemannSolverand some other classes were moved from the example to the library, inmfem/fem/hyperbolic.hpp. As a result, libROM fails to build with the latest MFEM. There are significant changes in MFEM, beyond just moving some classes to the library. Properly fixingdg_eulermay take some careful work. In the meantime, to fix the build immediately, I simply renamed the classes indg_euler.hppwith the prefixROM_, to avoid ambiguity.