-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/crkrenn/summary status #381
base: develop
Are you sure you want to change the base?
Conversation
enabled raw sbatch errors to be logged (LLNL#262)
sync with LLNL/develop
@crkrenn -- Thanks for the PR! I'll review this soon and let you know if I have any feedback. |
@daub1, FYI... |
It looks like the style check isn't working, but I also encountered style errors:
|
Co-authored-by: Francesco Di Natale <[email protected]>
@FrankD412, (cc: @jsemler @daub1 @ajkunen @antimatterhorn ) We have been hammering on maestro this week during a forensics exercise. We definitely would benefit from more flexibility in status reports. I've made the changes you requested (except the color... I use white backgrounds, so I'm happy if you propose a color you like). I don't know how to fix the readthedocs build error ("ModuleNotFoundError: No module named 'maestrowf'"). Can you help? Thanks! -Chris |
merge LLNL/dev
@jwhite242, Thanks for the suggestion! The readthedocs test is passing now too. |
@crkrenn -- I just looked through the changes again and it looks like you addressed everything. I just approved but feel free to continue to add commits if this isn't done. |
@FrankD412 (cc: @jwhite242), This is Chris, writing from Cody's account. We have no more planned changes to this pull request. Please merge into develop when you can. Thanks! -Chris |
@FrankD412 @jsemler
This is a very simple extension to
maestro status
which will let users monitor the progress of large studies (100's of steps) more easily. It was written withcodepy
in mind in that it groups results by the "run prefix", which corresponds to a "phase" incodepy
.With some more work, I can remove some more duplicate code betweenSummaryStatusRenderer
andFlatStatusRenderer
The latest version modifies
FlatStatusRenderer
so that it can be used as a base class for many different status outputs and so thatcodepy
developers can make changes more easily.I've also added a "narrow2" renderer that, in my mind, is much more useful for many workflows:
Please let me know if you have any questions.
Thanks!
-Chris