Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm Build #1228

Merged
merged 29 commits into from
Oct 8, 2024
Merged

ROCm Build #1228

merged 29 commits into from
Oct 8, 2024

Conversation

chapman39
Copy link
Collaborator

@chapman39 chapman39 commented Sep 11, 2024

Features:

  • Build TPLs on tioga/ rzvernal
  • Build Serac on tioga/ rzvernal (CPU)
  • Add tioga/ rzvernal host configs
  • Replace blt::cuda with CMake var ${serac_device_depends}, which is either blt::cuda, blt::hip, or set to an empty string if on a non-GPU build.
  • Test Tioga in CI
  • Add a HIP smoketest

@chapman39 chapman39 added the build Build system label Sep 11, 2024
@chapman39 chapman39 self-assigned this Sep 11, 2024
@chapman39
Copy link
Collaborator Author

having some trouble building petsc, so i created a spack issue. spack/spack#46468

if it ends up being unresolved, ill try a non petsc build.

@chapman39 chapman39 changed the title Tioga Build ROCm Build Sep 18, 2024
@chapman39
Copy link
Collaborator Author

petsc build works, though it required adding the -O0 flag. mfem is now failing during it's build step due to /usr/lib64/libopenblas.so:1:1: error: expected unqualified-id.

@@ -217,6 +227,11 @@ class Serac(CachedCMakePackage, CudaPackage):
# Conflicts
#

conflicts("+openmp", when="+rocm")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a comment on this conflict? Unlike cuda/rocm, this should work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure why this is needed, i just copied this from axom. I could test it out and see what happens when i try

https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/axom/package.py#L215

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't actually tried till now, but it results in a conflict anyway. since we propagate the openmp variant to axom, its conflict is in effect as well.

@chapman39 chapman39 marked this pull request as ready for review October 2, 2024 21:18
@chapman39 chapman39 requested a review from white238 October 2, 2024 21:18
@chapman39 chapman39 added CI Continuous Integration TPL Third-party libraries gpu GPU related labels Oct 2, 2024

set(CALIPER_DIR "${TPL_ROOT}/caliper-2.10.0-5yg5mgygsul5op4jgtxypp7jvtb5ojcc" CACHE PATH "")

# PETSC not built
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an issue to track we need to eventually turn back on PETSC for HIP

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@white238 white238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chapman39 !

@chapman39 chapman39 enabled auto-merge October 8, 2024 21:44
@chapman39 chapman39 merged commit 6299260 into develop Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system CI Continuous Integration gpu GPU related TPL Third-party libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants