-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROCm Build #1228
ROCm Build #1228
Conversation
having some trouble building petsc, so i created a spack issue. spack/spack#46468 if it ends up being unresolved, ill try a non petsc build. |
petsc build works, though it required adding the |
@@ -217,6 +227,11 @@ class Serac(CachedCMakePackage, CudaPackage): | |||
# Conflicts | |||
# | |||
|
|||
conflicts("+openmp", when="+rocm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a comment on this conflict? Unlike cuda/rocm, this should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure why this is needed, i just copied this from axom. I could test it out and see what happens when i try
https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/axom/package.py#L215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't actually tried till now, but it results in a conflict anyway. since we propagate the openmp variant to axom, its conflict is in effect as well.
… into feature/chapman39/tioga-build
… into feature/chapman39/tioga-build
|
||
set(CALIPER_DIR "${TPL_ROOT}/caliper-2.10.0-5yg5mgygsul5op4jgtxypp7jvtb5ojcc" CACHE PATH "") | ||
|
||
# PETSC not built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make an issue to track we need to eventually turn back on PETSC for HIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @chapman39 !
Features:
blt::cuda
with CMake var${serac_device_depends}
, which is eitherblt::cuda
,blt::hip
, or set to an empty string if on a non-GPU build.