CI Overhaul #309
Merged
CI Overhaul #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation of test_list.yaml, add py-pyyaml as a new TPL to be able to read in the performance test list
…rser from previous commit
…e inputs to adiak, updated testTimer to reflect these changes
…ingParser.py file instead of SpheralOptionParser.py, added ability to specify Adiak data directly from command line as a dictionary, update testTimer with adiakData tests and improved layout
…some new options for Noh tests, slight changes to performance.py
… files, changed SPHERAL_TEST_INSTALL_PREFIX to include tests directory, added tests for viz and restart files in SpheralController, created separate performance analysis python file
… parsing, removed use of None string in all existing tests, removed py-ats patch
…puts using less than symbol
…ht bash executable back for spheral_ats
… spheral_ats check if we are inside an allocation
…lean to host-config call in CI to avoid completely rebuilding when test is rerun
…pt cannot trigger a fail
mdavis36
requested changes
Nov 19, 2024
Comment on lines
+105
to
+123
| def _get_arch(self): | ||
| host_platform = spack.platforms.host() | ||
| host_os = host_platform.operating_system("default_os") | ||
| host_target = host_platform.target("default_target") | ||
| architecture = spack.spec.ArchSpec((str(host_platform), str(host_os), str(host_target))) | ||
| spack_arch = str(architecture) | ||
| return spack_arch.strip() | ||
|
|
||
| # Create a name for the specific configuration being built | ||
| # This name is used to differentiate timings during performance testing | ||
| def _get_config_name(self, spec): | ||
| arch = self._get_arch() | ||
| config_name = f"{arch}_{spec.compiler.name}_{spec.compiler.version}" | ||
| if ("+mpi" in spec): | ||
| config_name += "_" + spec.format("{^mpi.name}_{^mpi.version}") | ||
| if ("+cuda" in spec): | ||
| config_name += "_" + spec.format("{^cuda.name}{^cuda.version}") | ||
| return config_name.replace(" ", "_") | ||
|
|
There was a problem hiding this comment.
Why not do this in CMake?
There was a problem hiding this comment.
Some of this relies on Spack internal methods for determining things. We would have to extract those methods into CMake otherwise.
There was a problem hiding this comment.
I would prefer if we can do this during the CMake config stage at some point rather than relying on spack to generate a CMake string, but this is okay for now.
…ml and install-from-dev-pkg, fixed recursive module bug from last commit
mdavis36
reviewed
Nov 26, 2024
mdavis36
requested changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testsdirectoryToDo :
RELEASE_NOTES.mdwith notable changes.