Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing back our old ASPH idealH algorithm as a new option, ASPHClassic #322

Merged
merged 15 commits into from
Jan 9, 2025
Merged

Bringing back our old ASPH idealH algorithm as a new option, ASPHClassic #322

merged 15 commits into from
Jan 9, 2025

Conversation

jmikeowen
Copy link
Collaborator

@jmikeowen jmikeowen commented Jan 4, 2025 •
edited
Loading

Summary

  • This PR is a feature
  • It does the following:
    • Bringing back our old summation IdealH ASPH formalism as an option. This is useful for cases with relatively reasonable aspect ratios and is much faster than our current more robust Voronoi based option.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmikeowen jmikeowen added this to the 2025.01.0 Release milestone Jan 4, 2025
@jmikeowen jmikeowen self-assigned this Jan 4, 2025
@jmikeowen jmikeowen requested a review from ptsuji January 7, 2025 21:47
@jmikeowen jmikeowen merged commit 0ad6173 into develop Jan 9, 2025
1 check passed
@jmikeowen jmikeowen deleted the feature/ASPHClassic branch January 9, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptsuji ptsuji ptsuji approved these changes

Assignees

@jmikeowen jmikeowen

Labels
None yet
Projects
None yet
Milestone
2025.01.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikeowen @ptsuji