Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sprkstep #290

Merged
merged 180 commits into from
Jul 19, 2023
Merged

Feature/sprkstep #290

merged 180 commits into from
Jul 19, 2023

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Jun 19, 2023

Todo:

Rendered docs can be viewed here: https://sundials.readthedocs.io/en/feature-sprkstep/index.html

Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed everything except src/arkode/arkode_sprkstep.c. I'll look at that tomorrow.

CHANGELOG.md Outdated Show resolved Hide resolved
doc/arkode/guide/source/ARKodeSPRKStorage.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/ARKodeSPRKStorage.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/ARKodeSPRKStorage.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/ARKodeSPRKStorage.rst Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Show resolved Hide resolved
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great. I tried to give "suggestions" for all easily-fixable items to streamline the update process.

src/arkode/arkode_sprkstep.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep.c Show resolved Hide resolved
doc/arkode/guide/source/ARKodeSPRKStorage.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/ARKodeSPRKStorage.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Show resolved Hide resolved
src/arkode/arkode_sprk.c Show resolved Hide resolved
src/arkode/arkode_sprkstep.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great. I have only a few more items to resolve before I think this is ready.

doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
include/arkode/arkode_sprkstep.h Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_sprkstep_io.c Show resolved Hide resolved
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I think all that's needed is to update the answer files for the GitHub CI and once those are merged update the submodule commit here.

@gardner48 gardner48 merged commit 6dd81ab into develop Jul 19, 2023
14 checks passed
@gardner48 gardner48 deleted the feature/sprkstep branch July 19, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants