-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sprkstep #290
Feature/sprkstep #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed everything except src/arkode/arkode_sprkstep.c
. I'll look at that tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great. I tried to give "suggestions" for all easily-fixable items to streamline the update process.
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great. I have only a few more items to resolve before I think this is ready.
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
doc/arkode/guide/source/Usage/SPRKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
…der 1, issue still for more than one stage)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I think all that's needed is to update the answer files for the GitHub CI and once those are merged update the submodule commit here.
Todo:
Rendered docs can be viewed here: https://sundials.readthedocs.io/en/feature-sprkstep/index.html