-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/oo adaptivity2 #358
Conversation
…ing David's suggestion in feature/oo-adaptivity PR review
…aptMem, so that it would be easier to deprecate the idea later on
…ifying SUNAdaptController API
…instead pass that in as argument to EstimateStep
…o feature/oo-adaptivity2
… created SUNAdaptController_Soderlind utility routines for these modules
…ng them into the Soderlind controller
…/answers to point to corresponding PR commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor updates to note a deprecated function. Also looks like the output files need to be updated after recent changes in develop. I'll update the output files from Jenkins in a sec.
…ation to appropriate location in arkstep_*step_io.c
I don't quite understand your final sentence -- are you planning to update the full set of answer files that are failing due to the merge in the CI, or just those that relate to the Jenkins box? Or more simply, which answer files are you not planning to update and that I'll need to handle? |
I've updated the failing output files from Jenkins so that should pass on the next run of tests. I also updated the answers submodule for GitHub CI to the latest commit in the answers repo but this will likely not resolve conflicting changes and another PR in the answers repo will be needed to update those files again. |
Sounds good. I'll wait for the CI tests to all finish (including failures) and then update the answers repo as necessary. |
I cannot log into ci/gitlab/lc.llnl.gov, so I don't know why that build/test is failing. |
Update answers for LLNL/sundials#358 --------- Co-authored-by: Daniel R. Reynolds <[email protected]>
New object-oriented infrastructure for time step adaptivity controllers. --------- Co-authored-by: David J. Gardner <[email protected]> Co-authored-by: Balos, Cody, J <[email protected]> Co-authored-by: Cody Balos <[email protected]>
New object-oriented infrastructure for time step adaptivity controllers. --------- Co-authored-by: David J. Gardner <[email protected]> Co-authored-by: Balos, Cody, J <[email protected]> Co-authored-by: Cody Balos <[email protected]>
New object-oriented infrastructure for time step adaptivity controllers. These are currently used in ARKODE. In the not-distant future, we can implement additional step/order controllers within this existing infrastructure to support CVODE(S) and IDA(S) (and maybe even ARKODE).
Also: