Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove deprecated code #360

Merged
merged 52 commits into from
Nov 13, 2023
Merged

Feature/remove deprecated code #360

merged 52 commits into from
Nov 13, 2023

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Oct 27, 2023

No description provided.

drreynolds
drreynolds previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, it feels nice deleting this old stuff!

examples/kinsol/serial/kinAnalytic_fp.c Outdated Show resolved Hide resolved
examples/kinsol/serial/kinAnalytic_fp.c Outdated Show resolved Hide resolved
examples/kinsol/serial/kinLaplace_picard_kry.c Outdated Show resolved Hide resolved
examples/kinsol/serial/kinLaplace_picard_kry.c Outdated Show resolved Hide resolved
@balos1 balos1 added this to the SUNDIALS Next milestone Oct 31, 2023
@drreynolds drreynolds self-requested a review November 3, 2023 18:17
balos1 and others added 19 commits November 4, 2023 22:07
@balos1
remove deprecated arkode code
d445aa5
@balos1
remove direct and spils header files
e57f71c
@balos1
remove kinsol deprecated code
106901b
@balos1
more changes for the removal of spils and direct
5934bf2
@balos1
remove more deprecated code
7091261
@balos1
update swig
0388073
@balos1 @drreynolds
Apply suggestions from code review
b77a568 
Co-authored-by: Daniel R. Reynolds <[email protected]>
@balos1 @drreynolds
Feature: Fortran interface for lapack dense solver (#353)
bce63fb 
Added Fortran support for the LAPACK dense SUNLinearSolver implementation.

---------

Co-authored-by: Daniel R. Reynolds <[email protected]>
@balos1
remove implementation of SUNLinsSol and SUNNonlinSol printinfo functions
1c76c85
@balos1
replace use of SetDiagnostics in some arkode examples
841a6d9
@balos1
make INFO level the default for logging
5179287
@balos1
change arkode INFO logging to DEBUG
196c32a
@balos1
add debugging filename
e47a8c3
@balos1
clean up use of removed functions
32501fa
@balos1
clean removed functions in benchmarks
3ebc682
@balos1
remove _spils and _direct references
1652153
@balos1
remove cpodes script
3841cd5
@balos1
cleanup use of removed PREC_ macro
b816971
@balos1
remove unused flag
3cd7a85
@balos1 balos1 force-pushed the feature/remove-deprecated-code branch from 1013c3f to 3cd7a85 Compare November 5, 2023 05:09
@balos1 balos1 removed the dont-merge label Nov 5, 2023
@gardner48
Copy link
Member

gardner48 commented Nov 10, 2023 •
edited
Loading

Your fixes to the C++ interfaces to add SUNComm reminded me we should probably remove things like

/* We include this here for backwards compatibility
   (the contents used to be defined here directly) */
#include <sundials/sundials_context.hpp>

in sundials_context.h and have C++ users include the .hpp file. I think this only occurs in sundials_context.h and sundials_profiler.h.

@balos1
Copy link
Member Author

balos1 commented Nov 10, 2023

Your fixes to the C++ interfaces to add SUNComm reminded me we should probably remove things like

/* We include this here for backwards compatibility
   (the contents used to be defined here directly) */
#include <sundials/sundials_context.hpp>

in sundials_context.h and have C++ users include the .hpp file. I think this only occurs in sundials_context.h and sundials_profiler.h.

Lets leave this for the error handling PR because i rearranged some includes there

@balos1
Copy link
Member Author

balos1 commented Nov 12, 2023 •
edited
Loading

GitLab CI is reporting as failed since Corona is (or was) down, i'll restart them.

@balos1
Copy link
Member Author

balos1 commented Nov 12, 2023

GitLab CI is reporting as failed since Corona is (or was) down, i'll restart them.

OK, all (minus extended) are passing now.

@gardner48 gardner48 merged commit 551f676 into develop Nov 13, 2023
18 of 20 checks passed
@gardner48 gardner48 deleted the feature/remove-deprecated-code branch November 13, 2023 14:34
@balos1 balos1 mentioned this pull request Dec 14, 2023
Closed
gardner48 pushed a commit that referenced this pull request Dec 18, 2023
@balos1 @drreynolds @gardner48
Remove deprecated code (#360)
5823879 
Remove deprecated functions

---------

Co-authored-by: Daniel R. Reynolds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drreynolds drreynolds drreynolds approved these changes

@gardner48 gardner48 gardner48 approved these changes

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Assignees
No one assigned
Labels
api-change
Projects
None yet
Milestone
SUNDIALS v7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@balos1 @gardner48 @drreynolds