Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (mingw): Install and build with SuiteSparse library #432

Merged
merged 4 commits into from
May 16, 2024

Conversation

mmuetzel
Copy link
Contributor

MSYS2 follows a rolling release model. I.e., most of its packages are quite new most of the time.
Adding the SuiteSparse libraries in the CI tests for MSYS2 might help to detect potentially API changes early.

@balos1
Copy link
Member

balos1 commented May 13, 2024

@mmuetzel Can you sign your commit as mentioned in the contributing guide?

@mmuetzel
Copy link
Contributor Author

@mmuetzel Can you sign your commit as mentioned in the contributing guide?

I rebased on a current head of the develop branch and added the Signed-off-by at the end of the commit message.
Is that correct?

@balos1
Copy link
Member

balos1 commented May 15, 2024

@mmuetzel Can you sign your commit as mentioned in the contributing guide?

I rebased on a current head of the develop branch and added the Signed-off-by at the end of the commit message. Is that correct?

Yes, it looks good now.

@mmuetzel
Copy link
Contributor Author

It looks like the CI failed because GCC 14 is stricter when it comes to automatically converting pointer types than previous versions.
That is probably worth fixing independently.

@mmuetzel
Copy link
Contributor Author

I opened #477 which hopefully addresses that issue.
(IIUC, that is a real issue indeed if SUNDIALS_INT64_T is defined on Windows or other platforms that use an LLP64 data model.)

balos1 added a commit that referenced this pull request May 15, 2024
`long int` is 32 bits wide on systems that use an LLP64 data model
(e.g., Windows). Use a type for which the C standard guarantees that it
is 64-bit instead (i.e., `int64_t`).

See the error in CI for PR #432.

Signed-off-by: Markus Mützel <[email protected]>
Co-authored-by: Cody Balos <[email protected]>
@balos1 balos1 merged commit 9ebc406 into LLNL:develop May 16, 2024
19 checks passed
gardner48 pushed a commit that referenced this pull request Jun 20, 2024
`long int` is 32 bits wide on systems that use an LLP64 data model
(e.g., Windows). Use a type for which the C standard guarantees that it
is 64-bit instead (i.e., `int64_t`).

See the error in CI for PR #432.

Signed-off-by: Markus Mützel <[email protected]>
Co-authored-by: Cody Balos <[email protected]>
gardner48 added a commit that referenced this pull request Jun 20, 2024
MSYS2 follows a rolling release model. I.e., most of its packages are
quite new most of the time.
Adding the SuiteSparse libraries in the CI tests for MSYS2 might help to
detect potentially API changes early.

Signed-off-by: Markus Mützel <[email protected]>
Co-authored-by: Cody Balos <[email protected]>
Co-authored-by: David Gardner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants