Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUNStepper basics based on MRIStepInnerStepper #463
base: develop
Are you sure you want to change the base?
SUNStepper basics based on MRIStepInnerStepper #463
Changes from 17 commits
1267d97
19f921c
ca7768e
bf3d836
b96f1ee
e87e70f
86db0fe
02fcf40
c04f24a
f9ff00c
49e902c
4be592c
1a92308
3c3a406
cbfbd79
e6815d6
c7d3f39
b7d7e08
491765f
bc58f0c
e262fb6
7881ddc
5e03e95
40ee734
a082c34
cb6b0fd
4e0784a
7ba3a87
5a110e3
32d6f3d
9980090
b928595
d3ca3b8
1672e09
12e1c2b
319d899
da6e773
a4fc856
cd12b43
c7b6cde
0c1b84c
9d32e88
01eba9e
13e444e
03e26d6
9f6baab
b1a3dad
50cb5a1
ec8bbde
2a05e5d
92a7f17
24114fe
ef116d5
68e1d1e
e24ed27
aa7ccc1
ec41dfa
106022a
81fa70f
9e95184
7158562
f9dc452
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to propose removing the
mode
argument since it's specific to ARKODE and I don't see any general need for it. Currently, the MRI and operator splitting methods always useARK_FULLRHS_OTHER
mode, and the other modes are unused. Any objections/concerns?