Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to disable interpolation in ARKODE #474

Merged
merged 27 commits into from
May 23, 2024

Conversation

gardner48
Copy link
Member

@gardner48 gardner48 commented May 12, 2024

Add support for disabling interpolated output in ARKODE steppers by passing ARK_INTERP_NONE to ARKodeSetInterpolantType. Disabling interpolation can reduce the memory footprint of an integrator by two or more state vectors (depending on the interpolation type and degree) which can be beneficial when interpolation is not needed e.g., when integrating to a final time without output in between or using an explicit fast time scale integrator with MRIStep.

When interpolation is disabled, rootfinding is not supported, implicit methods must use the trivial predictor, interpolation at stop times cannot be used, and calls to ARKodeEvolve in ARK_NORMAL mode will return at or past the requested output time.

@balos1 balos1 added this to the SUNDIALS Next milestone May 13, 2024
Copy link
Member

@balos1 balos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments

doc/arkode/guide/source/Usage/User_callable.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Usage/User_callable.rst Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
doc/arkode/guide/source/Usage/User_callable.rst Outdated Show resolved Hide resolved
doc/shared/RecentChanges.rst Outdated Show resolved Hide resolved
src/arkode/arkode_interp.c Outdated Show resolved Hide resolved
src/arkode/arkode_interp.c Outdated Show resolved Hide resolved
@balos1 balos1 requested a review from drreynolds May 23, 2024 15:46
drreynolds
drreynolds previously approved these changes May 23, 2024
balos1
balos1 previously approved these changes May 23, 2024
gardner48 added a commit to sundials-codes/answers that referenced this pull request May 23, 2024
@balos1 balos1 merged commit db65654 into develop May 23, 2024
22 checks passed
@balos1 balos1 deleted the feature/no-interpolation-2 branch May 23, 2024 22:42
gardner48 added a commit that referenced this pull request Jun 20, 2024
Add support for disabling interpolated output in ARKODE steppers by
passing `ARK_INTERP_NONE` to `ARKodeSetInterpolantType`. Disabling
interpolation can reduce the memory footprint of an integrator by two or
more state vectors (depending on the interpolation type and degree)
which can be beneficial when interpolation is not needed e.g., when
integrating to a final time without output in between or using an
explicit fast time scale integrator with MRIStep.

When interpolation is disabled, rootfinding is not supported, implicit
methods must use the trivial predictor, interpolation at stop times
cannot be used, and calls to `ARKodeEvolve` in `ARK_NORMAL` mode will
return at or past the requested output time.

---------

Co-authored-by: Cody Balos <[email protected]>
Co-authored-by: Daniel R. Reynolds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants