Maintenance: Add Maybe Unused Macro #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/arkode/arkode_adapt.c src/arkode/arkode_butcher.c src/sundials/sundials_hashmap.c
Conflicts: cmake/SundialsSetupCompilers.cmake examples/arkode/CXX_parallel/ark_heat2D_p.cpp examples/arkode/CXX_parhyp/ark_heat2D_hypre_ls.cpp examples/arkode/CXX_parhyp/ark_heat2D_hypre_pfmg.cpp examples/cvode/CXX_parallel/cv_heat2D_p.cpp examples/cvode/CXX_parhyp/cv_heat2D_hypre_ls.cpp examples/cvode/CXX_parhyp/cv_heat2D_hypre_pfmg.cpp src/nvector/manyvector/nvector_manyvector.c
|
Opening draft PR for testing |
balos1
reviewed
May 21, 2024
drreynolds
reviewed
May 25, 2024
There was a problem hiding this comment.
It's my impression that the "unused" warnings are originally intended to help developers clean up their code. It looks like those warnings have identified multiple locations where we could stand some cleanup. I'd prefer that this PR actually fix those items than plaster over them with the SUNDIALS_MAYBE_UNUSED macro.
drreynolds
previously approved these changes
May 29, 2024
balos1
approved these changes
May 30, 2024
gardner48
added a commit
that referenced
this pull request
Jun 20, 2024
Add `SUNDIALS_MAYBE_UNUSED` macro to suppresses warnings on unused entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SUNDIALS_MAYBE_UNUSEDmacro to suppresses warnings on unused entities.