-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/arkode sts #541
base: develop
Are you sure you want to change the base?
Feature/arkode sts #541
Conversation
Unfortunately, the rebase to |
12940d0
to
62bccbd
Compare
Yeah, I think in the future we should not rebase develop on main (if main is updated directly) and instead do a merge. I don't see a real advantage to having the same linear history for main and develop, and it seems the rebase has a pretty big downside. |
Indeed. Although rebasing might be no big deal for branches with 1-2 commits, it is a huge waste of time for a branch with any appreciable amount of development. |
This text sundials/doc/arkode/guide/source/Usage/User_callable.rst Lines 48 to 52 in 6117e71
and sundials/doc/arkode/guide/source/Usage/User_callable.rst Lines 60 to 61 in 6117e71
need to be updated. This list of steppers is growing long and text like this easily gets overlooked, so I think more generic statements without a long list of links would be ok. |
batch commit Co-authored-by: David Gardner <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]>
This is a draft PR for feedback on new STS module.