Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/arkode sts #541

Open
wants to merge 287 commits into
base: develop
Choose a base branch
from
Open

Feature/arkode sts #541

wants to merge 287 commits into from

Conversation

maggul
Copy link
Collaborator

@maggul maggul commented Jul 12, 2024

This is a draft PR for feedback on new STS module.

@drreynolds
Copy link
Collaborator

Unfortunately, the rebase to develop seems to have marked hundreds of files as conflicts. I'll work on fixing this branch now, so that it will be easier for folks to review.

@balos1
Copy link
Member

balos1 commented Jul 12, 2024

Unfortunately, the rebase to develop seems to have marked hundreds of files as conflicts. I'll work on fixing this branch now, so that it will be easier for folks to review.

Yeah, I think in the future we should not rebase develop on main (if main is updated directly) and instead do a merge. I don't see a real advantage to having the same linear history for main and develop, and it seems the rebase has a pretty big downside.

@drreynolds
Copy link
Collaborator

and it seems the rebase has a pretty big downside.

Indeed. Although rebasing might be no big deal for branches with 1-2 commits, it is a huge waste of time for a branch with any appreciable amount of development.

@Steven-Roberts
Copy link
Collaborator

This text

In the function descriptions below, we identify those that have any of the restrictions B-E above.
Then in the introduction for each of the stepper-specific documentation sections
(:numref:`ARKODE.Usage.ARKStep.UserCallable`, :numref:`ARKODE.Usage.ERKStep.UserCallable`,
:numref:`ARKODE.Usage.MRIStep.UserCallable`, and :numref:`ARKODE.Usage.SPRKStep.UserCallable`)
we clarify the categories of these functions that are supported.

and

For functions to create an ARKODE stepper instance see :c:func:`ARKStepCreate`,
:c:func:`ERKStepCreate`, :c:func:`MRIStepCreate`, or :c:func:`SPRKStepCreate`.

need to be updated.

This list of steppers is growing long and text like this easily gets overlooked, so I think more generic statements without a long list of links would be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants