Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Energy APIs: Print and JSON (PR from fork/304) #530

Merged
merged 55 commits into from
Mar 25, 2024
Merged

Energy APIs: Print and JSON (PR from fork/304) #530

merged 55 commits into from
Mar 25, 2024

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Mar 15, 2024 •
edited
Loading

Original PR is #304.

Fixes #209

TODO:

  • JSON implementation on IBM
  • JSON implementation on Intel
  • Multi-architecture build should not call the GPU platforms
  • Get energy for Intel
  • Update print energy output and print verbose output to match other APIs.
  • Update print-verbose-energy example

Commit message:
Add support for get/print energy APIs

Expands support for variorum_print_energy and adds two new APIs -- variorum_print_verbose_energy, variorum_get_energy_json on Intel and IBM platforms.

tpatki and others added 30 commits October 11, 2022 12:53
@tpatki
Initial setup to add variorum_print_energy (archs other than AMD) and…
cf3f474 
… variorum_print_verbose_energy (all archs.) APIs.
@tpatki
Merge branch 'dev' into add_print_energy_impl
905a5f9
@tpatki
Merge branch 'dev' into add_print_energy_impl
40b6e1d
@tpatki
Stub now builds on Lassen (CPU-only)
acfe66c
@tpatki
Work in progress for sampling thread
b5c0815
@tpatki
Fix some, but not all, build errors
d3928d5
@tpatki
Formatted files.
abc85e4
@tpatki
Build but has pthread/mutex issues and doesn't work correctly. Saving…
d3d867f 
… WIP so I can pick up debugging later.
@tpatki
Format and save current state. Example builds but doesn't call the ta…
1070d69 
…ke_measurement function, may have to do with variorum_timers usage
@slabasan
put return inside if check
ee59784
@slabasan
fix sampling code, add 2s sleep to print energy example
adbcaf7
@amarathe84
Fixed pthread_attr_destroy issue, changed scope of variables used by …
809e107 
…the sampling thread
@amarathe84
Added energy measurement in IBM P9
11aebd8
@tpatki
Merge branch 'dev' into add_print_energy_impl
2ea2c63
@amarathe84
Merged changes from tpatki/dev with the recent commit
968ea9e
@amarathe84
Print energy support for Intel Broadwell and Haswell
13eb162
@tpatki
Formatting pass.
4208fb9
@tpatki
Add variorum_get_energy_json API for IBM
a85a615
@tpatki
Add missing example file
d7e370a
@tpatki
To resolve conflicts, first restore to dev
dd0b4fd
@tpatki
Next, add the print energy support functions
b8471ba
@tpatki
Resolve conflicts, attempt 2. Had to pull from upstream, not origin
7f3dda5
@tpatki
Next, add the print energy fns. Shouldn't have conflicts or incorrect…
1017e56 
…ly deleted libjustify checks anymore
@tpatki
Ugh. Let's try that again. Rebase origin's dev, and checkout the dev'…
67afcc2 
…s file again
@tpatki
Trying again.
8a8cdd2
@tpatki
Merge branch 'LLNL:dev' into add_print_energy_impl
7f8ebfd
@tpatki
Fix uninitialized variable warnings in print_energy functions
4329b7d
@tpatki
Fixed minor copy paste error
ba7be33
@tpatki
Merge branch 'dev' into add_print_energy_impl
2a4d8b8
@slabasan
reorder examples alphabetically
2ec71ee
slabasan and others added 10 commits March 19, 2024 12:17
@slabasan
fix input parameters
b75be03
@slabasan
fixes
4888b89 
- update print-verbose-energy example to call API a second time
- fix accumulated printout from after to before
@slabasan
update print/print-verbose energy example outputs to match others
6fec55f 
_IBMENERGY Host AccumulatedEnergy Timestamp_sec
_IBMENERGY lassen 0 0.000018
_IBMENERGY lassen 676250 2.000127
start get energy json on intel
6031377
@slabasan
formatting
0d6f603
@slabasan
implement intel json
b391db7
@slabasan
fix warnings
d82a6b1
@slabasan
formatting fixes
62ec7ac
correct watts to energy
a10af2f
add DRAM energy, fix output formatting
33bd625
@slabasan slabasan requested a review from tpatki March 22, 2024 21:02
@slabasan slabasan added status-ready-for-review Formatted, and tested on multiple systems. type-feature area-feature-support labels Mar 22, 2024
@slabasan slabasan added this to the Production: v0.8.0 Release milestone Mar 22, 2024
@slabasan slabasan merged commit 790446f into dev Mar 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpatki tpatki Awaiting requested review from tpatki

Assignees
No one assigned
Labels
area-feature-support status-ready-for-review Formatted, and tested on multiple systems. type-feature
Projects
None yet
Milestone
Production: v0.8.0 Release
Development

Successfully merging this pull request may close these issues.

Add support for variorum_print_energy API on other architectures
3 participants
@slabasan @tpatki @amarathe84