Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return statement for missing platforms in variourm_get_energy_json #538

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

kulnaman
Copy link
Collaborator

@kulnaman kulnaman commented Apr 2, 2024

Description

There is a missing return statement in the variourm_get_energy_json causing a segfault; This pull request will resolve this.

Fixes #537, closes #539

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.

  • Test A: Hardware architecture, machine name, example/test run
  • Test B: Hardware architecture, machine name, example/test run
  • ...

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

@slabasan slabasan mentioned this pull request Apr 3, 2024
@slabasan slabasan merged commit 28c74a9 into LLNL:dev Apr 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in variorum_get_energy_json Due to Missing Return Statement in Error Handling
2 participants