Fix linking with APMIDG for Intel GPUs

[masterleinad]

Description

Without this pull request Variorum doesn't link against APMIDG resulting in linker errors. This pull request is also fixing some compiler warnings. In particular, the str array is never NULL making one check obsolete. The success of writing into this array via fgets is already checked above.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature/architecture support (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Build/CI update

How Has This Been Tested?

Building and testing on ALCF's sunspot testbed.

Checklist:

• I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
• I have added comments in my code
• My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
• New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

[tpatki]

Hi @masterleinad ! Thank you for this, we don't have access to Intel GPUs so we can't test this at our end (Kaz @kazutomo tested it for us before).

• Can you run the scripts/check-code-format.sh script and address the code formatting issue? Let me know if you have trouble setting this up at your end, I can take care of it as well.
• Can you attach a sunspot host-config file as well for other users at ANL?

[masterleinad]

Can you run the scripts/check-code-format.sh script and address the code formatting issue? Let me know if you have trouble setting this up at your end, I can take care of it as well.

I tried doing that but ran into

> ./scripts/check-code-format.sh 
Checking format of cpp/c/h files using astyle
Invalid command line options:
	max-instatement-indent=40
	break-closing-brackets
	add-brackets
For help on options type 'astyle -h'
Artistic Style has terminated

'rstfmt' not found: this package can be installed using pip

Do I need a particular version?

[tpatki]

Hi @masterleinad Thanks for the prompt reply! I don't think you need a particular version. I can format this for you if it doesn't work easily at your end, let me know accordingly.

[masterleinad]

Hi @masterleinad Thanks for the prompt reply! I don't think you need a particular version. I can format this for you if it doesn't work easily at your end, let me know accordingly.

Using 3.1 worked now.

[masterleinad]

Can you attach a sunspot host-config file as well for other users at ANL?

I needed to install jansson and apmidg myself. I'm not quite sure what the path forward would be.

[tpatki]

Ah, I see. Maybe a template or example host-config then, that people can copy and add the path to APMIDG. Jansson is already a Variorum dependency so folks would know how to set that up.