Skip to content

Commit

Permalink
Merge pull request #394 from basz/minor-tweak
Browse files Browse the repository at this point in the history
Minor tweak
  • Loading branch information
prolic authored Jan 17, 2020
2 parents 5473608 + 031a312 commit 3bd3fdb
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 10 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ composer.lock
.idea
.php_cs.cache
build
.phpunit.result.cache
14 changes: 10 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,24 @@ cache:

matrix:
include:
- php: 7.1
- php: 7.2
env:
- DEPENDENCIES=""
- EXECUTE_CS_CHECK=true
- TEST_COVERAGE=true
- php: 7.1
- php: 7.2
env:
- DEPENDENCIES="--prefer-lowest --prefer-stable"
- php: 7.2
- php: 7.3
env:
- DEPENDENCIES=""
- php: 7.2
- php: 7.3
env:
- DEPENDENCIES="--prefer-lowest --prefer-stable"
- php: 7.4
env:
- DEPENDENCIES=""
- php: 7.4
env:
- DEPENDENCIES="--prefer-lowest --prefer-stable"

Expand Down
5 changes: 3 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,14 @@
}
],
"require": {
"php": "^7.1",
"php": "^7.2",
"zendframework/zend-servicemanager": "^3.3",
"zendframework/zend-stdlib": "^3.1"
},
"require-dev": {
"malukenho/docheader": "^0.1.7",
"phpunit/phpunit": "^7.5.6",
"phpunit/phpunit": "^8.5.2",
"phpspec/prophecy": "^1.10",
"friendsofphp/php-cs-fixer": "^2.9.3",
"doctrine/common": "^2.4",
"satooshi/php-coveralls": "^2.0"
Expand Down
2 changes: 1 addition & 1 deletion src/ConfigProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
*/
final class ConfigProvider
{
public function __invoke()
public function __invoke(): array
{
return [
'dependencies' => $this->getDependencyConfig(),
Expand Down
2 changes: 1 addition & 1 deletion src/Module.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ final class Module
/**
* Return default ZfcRbac configuration for zend-mvc applications.
*/
public function getConfig()
public function getConfig(): array
{
$provider = new ConfigProvider();

Expand Down
4 changes: 2 additions & 2 deletions test/Options/ModuleOptionsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ public function testAssertModuleDefaultOptions(): void
$moduleOptions = new \ZfcRbac\Options\ModuleOptions();

$this->assertEquals('guest', $moduleOptions->getGuestRole());
$this->assertInternalType('array', $moduleOptions->getRoleProvider());
$this->assertInternalType('array', $moduleOptions->getAssertionMap());
$this->assertIsArray($moduleOptions->getRoleProvider());
$this->assertIsArray($moduleOptions->getAssertionMap());
}

public function testSettersAndGetters(): void
Expand Down

0 comments on commit 3bd3fdb

Please sign in to comment.