Remove unused direct dependency on abandoned laminas-config. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Demian Katz <[email protected]>
|
Thanks @demiankatz. I will look at it over the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The laminas-config library has been abandoned. This component has a direct dependency on laminas-config in composer.json, yet it does not use any code in the Laminas\Config namespace; thus, I do not believe this direct dependency is needed.
Note that because laminas-modulemanager still depends on laminas-config, the changes here will not actually change which dependencies get installed... but I expect that laminas-modulemanager will eventually drop laminas-config, and when that happens, removing the abandoned dependency here should prove helpful.