Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Channel on top of sunkit_instruments.response.abstractions.AbstractChannel #344

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wtbarnes
Copy link
Contributor

@wtbarnes wtbarnes commented Sep 18, 2024

This is a first attempt at refactoring the Channel class on top of the AbstractChannel class from sunkit-instruments. The latter is still in the form of a draft PR sunpy/sunkit-instruments#98 so this is an experimental PR at this stage.

The goal here is to easily enable calculating the temperature response functions.

As it stands, this represents a breaking change to the Channel API.

ToDos before this can be merged:

Summary by Sourcery

Refactor the Channel class to extend AbstractChannel, enhancing the API with additional parameters and methods for more flexible and accurate temperature response function calculations. This change introduces a breaking change to the Channel API.

Enhancements:

  • Refactor the Channel class to inherit from AbstractChannel, introducing a more structured approach to handling channel properties and response functions.
  • Add new parameters to the Channel class constructor, including include_eve_correction, include_crosstalk, correction_table, and calibration_version, to enhance flexibility in response function calculations.
  • Rename several properties for clarity, such as primary_reflectance to primary_mirror_reflectance and focal_plane_filter_efficiency to focal_plane_filter_transmittance.
  • Introduce new methods and properties to handle complex calculations like mirror_reflectance, filter_transmittance, and energy_per_electron.

This comment was marked as resolved.

@wtbarnes wtbarnes marked this pull request as draft September 18, 2024 20:10
sourcery-ai[bot]

This comment was marked as resolved.

@wtbarnes wtbarnes force-pushed the sunkit-instr-channel-testing branch from 0d5ba02 to 9161613 Compare September 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant