Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make portsmf a git submodule #7755

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

rubiefawn
Copy link
Contributor

This makes portsmf, which is used in the MIDI import plugin, a git submodule.

@rubiefawn
Copy link
Contributor Author

Marking this as a draft while I test MIDI import for regressions. I have no idea what version of portsmf was previously being used vs whatever the current version is, so it could be completely broken for all I know.

@bratpeki bratpeki self-assigned this Mar 6, 2025
@tresf
Copy link
Member

tresf commented Mar 7, 2025

I have no idea what version of portsmf was previously being used vs whatever the current version is, so it could be completely broken for all I know.

Here's the diff.
https://gist.github.com/tresf/8427469c7f2ea670bb0e56f36cf8f349

Here's the commit history in LMMS:

The diff is probably enough to hand-patch and provide it upstream, however in doing so, it would probably make sense to do it for the entire project (not just the files we use from it).

When working on #3963, we had to do this for each several submodules. Fortunately for this one, most of the changes appear to be rather trivial.

@rubiefawn
Copy link
Contributor Author

It looks like my initial PR for upstream that fixes the compiler warnings got merged, so that's nice! I'll update the submodule.

@rubiefawn
Copy link
Contributor Author

noooo

I'm going to temporarily point the submodule at my fork while I fix all this, and then make a PR against upstream once it's compiling fine in here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants