Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset song queue on player stopped and queue finished #1216

Open
wants to merge 1 commit into
base: public/9.0
Choose a base branch
from

Conversation

ml-1
Copy link

@ml-1 ml-1 commented Nov 12, 2024

I saw #1213 and thought that this one might be interesting for others.

I've had this patch for some time in my tree and it's been working fine for me but I don't know if there are any other use cases that could be affected.

@michaelherger
Copy link
Member

What would this add in addition to d36d810?

@ml-1
Copy link
Author

ml-1 commented Nov 12, 2024

d36d810 only updates the playlist CURTRACK, this patch will reset the queue so that when you press play again it will start playing the first track in the queue. Reset will also trigger GUI to jump to the first track.

@michaelherger
Copy link
Member

Hehe... one of the reasons why that other change only addressed the stored playlist issue was that I'm not too familiar with the streaming controller. Your fix looks so simple, I can't believe it would be the real fix 😂. But as I said: I don't know this part of the code well. I'll hopefully find some time to look into this post 9.0 release.

@ml-1
Copy link
Author

ml-1 commented Nov 13, 2024

I'm not that familiar with the whole code base that's why I put the works for me disclaimer. When I started using LMS a couple of years ago it annoyed me that the queue was not reset when the playlist finished so I did some exploration a weekend and managed to come up with this patch.
Post 9.0 timeline sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants