Merge pull request #119 from LNP-BP/develop

Release v0.10.0 Beta 1

.github/workflows/build.yml

@@ -87,26 +87,3 @@ jobs:
         with:
           command: check
           args: --workspace --all-targets --all-features
-  dependency:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: Install latest stable
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          override: true
-      - name: Create dependency
-        run: |
-          cargo new dep_test
-          cp test/depCargo.toml dep_test/Cargo.toml
-          cd dep_test
-      - name: Build dependency
-        uses: actions-rs/cargo@v1
-        with:
-          command: check
-          args: --verbose
-      - name: Clean up
-        run: |
-          cd ..
-          rm -rf dep_test

CONTRIBUTING.md

@@ -1,63 +1,35 @@
-Contributing to LNP/BP projects
-===============================
+Contributing guidelines
+=======================
 
-:+1::tada: 
-First and foremost, thanks for taking the time to contribute!
-:tada::+1:
-
-The following is a set of guidelines for contributing to [LNP/BP Standards
-Association](https://lnp-bp.org) projects, which are hosted in the GitHub
-organizations listed in [readme](https://github.com/LNP-BP#Working-groups).
-These are mostly guidelines, not rules. Use your best judgment, and feel free to
-propose changes to this document in a pull request.
+Contributions are very welcome. When contributing code, please follow these
+simple guidelines.
 
 #### Table Of Contents
-- [General](#general)
-- [Communication channels](#communication-channels)
-- [Asking questions](#asking-questions)
 - [Contribution workflow](#contribution-workflow)
+    * [Proposing changes](#proposing-changes)
     * [Preparing PRs](#preparing-prs)
     * [Peer review](#peer-review)
 - [Coding conventions](#coding-conventions)
 - [Security](#security)
 - [Testing](#testing)
 - [Going further](#going-further)
 
+Overview
+--------
 
-General
--------
-The LNP/BP projects operate an open contributor model where anyone is welcome to 
-contribute towards development in the form of peer review, documentation, 
-testing and patches.
-
-Anyone is invited to contribute without regard to technical experience, 
-"expertise", OSS experience, age, or other concern. However, the development of 
-standards & reference implementations demands a high-level of rigor, adversarial 
-thinking, thorough testing and risk-minimization. Any bug may cost users real 
-money. That being said, we deeply welcome people contributing for the first time 
-to an open source project or pick up Rust while contributing. Don't be shy, 
-you'll learn.
-
-Communications Channels
------------------------
-Communication about LNP/BP standards & implementations happens primarily 
-on #lnp-pb IRC chat on Freenode with the logs available at 
-<http://gnusha.org/lnp-bp/>
-
-Discussion about code base improvements happens in GitHub issues and on pull
-requests.
-
-Major projects are tracked [here](https://github.com/orgs/LNP-BP/projects).
-Project roadmap is tracked in each repository GitHub milestones.
+* Before adding any code dependencies, check with the maintainers if this is okay.
+* Write properly formatted comments: they should be English sentences, eg:
 
-Asking Questions
-----------------
-> **Note:** Please don't file an issue to ask a question. Each repository - or
-> GitHub organization has a "Discussions" with Q&A section; please post your 
-> questions there. You'll get faster results by using this channel.
+        // Return the current UNIX time.
 
-Alternatively, we have a dedicated developer channel on IRC, #[email protected]
-where you may get helpful advice if you have questions.
+* Read the DCO and make sure all commits are signed off, using `git commit -s`.
+* Follow the guidelines when proposing code changes (see below).
+* Write properly formatted git commits (see below).
+* Run the tests with `cargo test --workspace --all-features`.
+* Make sure you run `rustfmt` on your code (see below details).
+* Please don't file an issue to ask a question. Each repository - or  
+  GitHub organization has a "Discussions" with Q&A section; please post your
+  questions there. You'll get faster results by using this channel.
 
 Contribution Workflow
 ---------------------
@@ -67,39 +39,49 @@ facilitates social contribution, easy testing and peer review.
 
 To contribute a patch, the workflow is a as follows:
 
-  1. Fork Repository
-  2. Create topic branch
-  3. Commit patches
+1. Fork Repository
+2. Create topic branch
+3. Commit patches
 
-In general commits should be atomic and diffs should be easy to read. For this 
-reason do not mix any formatting fixes or code moves with actual code changes. 
-Further, each commit, individually, should compile and pass tests, in order to 
+In general commits should be atomic and diffs should be easy to read. For this
+reason do not mix any formatting fixes or code moves with actual code changes.
+Further, each commit, individually, should compile and pass tests, in order to
 ensure git bisect and other automated tools function properly.
 
-When adding a new feature thought must be given to the long term technical debt. 
+When adding a new feature thought must be given to the long term technical debt.
 Every new features should be covered by unit tests.
 
 When refactoring, structure your PR to make it easy to review and don't hesitate
 to split it into multiple small, focused PRs.
 
-The Minimal Supported Rust Version is nightly for the period of active 
-development; it is enforced by our Travis. Later we plan to fix to some specific 
-Rust version after the initial library release.
-
 Commits should cover both the issue fixed and the solution's rationale.
-These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in 
+These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in
 mind.
 
-To facilitate communication with other contributors, the project is making use 
-of GitHub's "assignee" field. First check that no one is assigned and then 
-comment suggesting that you're working on it. If someone is already assigned, 
-don't hesitate to ask if the assigned party or previous commenters are still 
+To facilitate communication with other contributors, the project is making use
+of GitHub's "assignee" field. First check that no one is assigned and then
+comment suggesting that you're working on it. If someone is already assigned,
+don't hesitate to ask if the assigned party or previous commenters are still
 working on it if it has been awhile.
 
+### Proposing changes
+
+When proposing changes via a pull-request or patch:
+
+* Isolate changes in separate commits to make the review process easier.
+* Don't make unrelated changes, unless it happens to be an obvious improvement to
+  code you are touching anyway ("boyscout rule").
+* Rebase on `master` when needed.
+* Keep your changesets small, specific and uncontroversial, so that they can be
+  merged more quickly.
+* If the change is substantial or requires re-architecting certain parts of the
+  codebase, write a proposal in English first, and get consensus on that before
+  proposing the code changes.
+
 ### Preparing PRs
 
-The main library development happens in the `master` branch. This branch must 
-always compile without errors (using Travis CI). All external contributions are 
+The main library development happens in the `master` branch. This branch must
+always compile without errors (using Travis CI). All external contributions are
 made within PRs into this branch.
 
 Prerequisites that a PR must satisfy for merging into the `master` branch:
@@ -122,20 +104,60 @@ Additionally, to the `master` branch some repositories may have `develop` branch
 for any experimental developments. This branch may not compile and should not be
 used by any projects depending on the library.
 
+### Writing Git commit messages
+
+A properly formed git commit subject line should always be able to complete the
+following sentence:
+
+     If applied, this commit will _____
+
+In addition, it should be capitalized and *must not* include a period.
+
+For example, the following message is well formed:
+
+     Add support for .gif files
+
+While these ones are **not**: `Adding support for .gif files`,
+`Added support for .gif files`.
+
+When it comes to formatting, here's a model git commit message[1]:
+
+     Capitalized, short (50 chars or less) summary
+
+     More detailed explanatory text, if necessary.  Wrap it to about 72
+     characters or so.  In some contexts, the first line is treated as the
+     subject of an email and the rest of the text as the body.  The blank
+     line separating the summary from the body is critical (unless you omit
+     the body entirely); tools like rebase can get confused if you run the
+     two together.
+
+     Write your commit message in the imperative: "Fix bug" and not "Fixed bug"
+     or "Fixes bug."  This convention matches up with commit messages generated
+     by commands like git merge and git revert.
+
+     Further paragraphs come after blank lines.
+
+     - Bullet points are okay, too.
+
+     - Typically a hyphen or asterisk is used for the bullet, followed by a
+       single space, with blank lines in between, but conventions vary here.
+
+     - Use a hanging indent.
+
 ### Peer review
 
 Anyone may participate in peer review which is expressed by comments in the pull
 request. Typically reviewers will review the code for obvious errors, as well as
 test out the patch set and opine on the technical merits of the patch. PR should
-be reviewed first on the conceptual level before focusing on code style or 
+be reviewed first on the conceptual level before focusing on code style or
 grammar fixes.
 
 Coding Conventions
 ------------------
-Our CI enforces [clippy's](https://github.com/rust-lang/rust-clippy) 
+Our CI enforces [clippy's](https://github.com/rust-lang/rust-clippy)
 [default linting](https://rust-lang.github.io/rust-clippy/rust-1.52.0/index.html)
 and [rustfmt](https://github.com/rust-lang/rustfmt) formatting defined by rules
-in [.rustfmt.toml](./.rustfmt.toml). The linter should be run with current 
+in [.rustfmt.toml](./.rustfmt.toml). The linter should be run with current
 stable rust compiler, while formatter requires nightly version due to the use of
 unstable formatting parameters.
 
@@ -150,35 +172,25 @@ cargo +nightly fmt --all
 
 Security
 --------
-Security is the primary focus of LNP/BP libraries; disclosure of security 
-vulnerabilities helps prevent user loss of funds. If you believe a vulnerability 
-may affect other implementations, please inform them. Guidelines for a 
-responsible disclosure can be found in [SECURITY.md](./SECURITY.md) file in the
-project root.
-
-Note that some of LNP/BP projects are currently considered "pre-production".
-Such projects can be distinguished by the absence of `SECURITY.md`. In such 
-cases there are no special handling of security issues; please simply open 
+Responsible disclosure of security vulnerabilities helps prevent user loss of
+privacy. If you believe a vulnerability may affect other implementations, please
+inform them. Guidelines for a responsible disclosure can be found in 
+[SECURITY.md](./SECURITY.md) file in the project root.
+
+Note that some of our projects are currently considered "pre-production".
+Such projects can be distinguished by the absence of `SECURITY.md`. In such
+cases there are no special handling of security issues; please simply open
 an issue on GitHub.
 
-Testing
--------
-Related to the security aspect, LNP/BP developers take testing very seriously. 
-Due to the modular nature of the project, writing new functional tests is easy 
-and good test coverage of the codebase is an important goal.
-
-Fuzzing is heavily encouraged: feel free to add related material under `fuzz/`
-
-Mutation testing is planned; any contribution there would be warmly welcomed.
-
 Going further
 -------------
-You may be interested in Jon Atack guide on 
+You may be interested in Jon Atack guide on
 [How to review Bitcoin Core PRs][Review] and [How to make Bitcoin Core PRs][PR].
-While there are differences between the projects in terms of context and 
+While there are differences between the projects in terms of context and
 maturity, many of the suggestions offered apply to this project.
 
 Overall, have fun :)
 
+[1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 [Review]: https://github.com/jonatack/bitcoin-development/blob/master/how-to-review-bitcoin-core-prs.md
 [PR]: https://github.com/jonatack/bitcoin-development/blob/master/how-to-make-bitcoin-core-prs.md

Cargo.toml

@@ -12,7 +12,7 @@ default-members = [
 
 [package]
 name = "client_side_validation"
-version = "0.9.0"
+version = "0.10.0-beta.1"
 license = "Apache-2.0"
 authors = ["Dr. Maxim Orlovsky <[email protected]>"]
 description = "Client-side validation foundation library"
@@ -22,16 +22,16 @@ keywords = ["lnp-bp", "cryptocurrency", "smart-contracts", "blockchain"]
 categories = ["cryptography::cryptocurrencies", "encoding", "parsing"]
 readme = "README.md"
 edition = "2021"
-rust-version = "1.59.0"
+rust-version = "1.66.0"
 exclude = [".github", "commit_verify", "single_use_seals"]
 
 [lib]
 name = "client_side_validation"
 path = "src/lib.rs"
 
 [dependencies]
-commit_verify = { version = "0.9.0", path = "./commit_verify" }
-single_use_seals = { version = "0.9.0", path = "./single_use_seals" }
+commit_verify = { version = "0.10.0-beta.1", path = "./commit_verify" }
+single_use_seals = { version = "0.10.0-beta.1", path = "./single_use_seals" }
 serde_crate = { package = "serde", version = "1", features = ["derive"], optional = true }
 
 [features]
@@ -43,6 +43,3 @@ serde = ["serde_crate", "commit_verify/serde"]
 
 [package.metadata.docs.rs]
 features = [ "all" ]
-
-[patch.crates-io]
-strict_encoding = { git = "https://github.com/strict-types/strict-encoding" }