Fix verify functions' return type to be bool #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
changed the title
dr-orlovsky
requested review from
cryptoquick,
crisdut,
nicbus,
zoedberg and
fedsten
dr-orlovsky
added
*security*
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
cryptoquick
reviewed
Oct 15, 2023
| @@ -303,8 +293,8 @@ mod test { | |||
| impl<T> EmbedCommitProof<T, DummyVec, TestProtocol> for DummyProof | |||
| where T: AsRef<[u8]> + Clone + CommitEncode | |||
| { | |||
| fn restore_original_container(&self, _: &DummyVec) -> Result<DummyVec, Error> { | |||
| Ok(DummyVec(self.0.clone())) | |||
| fn restore_original_container(&self, _: &DummyVec) -> Option<DummyVec> { | |||
There was a problem hiding this comment.
Why change from Result to Option?
There was a problem hiding this comment.
This is internal method called from verify, which was relying on type VerifyError which is not there anymore. So there is no error type we can return from here.
|
Closing in favor of #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting v0.11, since it is a breaking API change