Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerized controller #388

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

enhaut
Copy link
Member

@enhaut enhaut commented Nov 7, 2024

Description

  • updated lnst contributors
  • moved agent's container files to container_files/agent
  • added support for running controller in container so you don't need to install
    lnst dependencies locally.

Tests

I am using it and it works as expected.

@Axonis
Copy link
Contributor

Axonis commented Nov 28, 2024

For the sake of consistency and reusability I'd like to see multistage build for the dockerfiles.
E.g. Using F39 in agent and F41 in controller can produce some weird results.

@enhaut
Copy link
Member Author

enhaut commented Dec 2, 2024

For the sake of consistency and reusability I'd like to see multistage build for the dockerfiles. E.g. Using F39 in agent and F41 in controller can produce some weird results.

I wanted to avoid muti stage build as it requires all the stages to be in a single file. So user would need to build all the stages - "base", agent and controller.

Splitting it into multiple files with base - agent/controller dependency requires user to build both base and agent/controller containers separately, and that's again something I wanted to avoid as I am using it, and I am kinda lazy to rebuild 2 containers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants