Fixes to compile on Rolling. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROS 2 Rolling has made two changes that cause this package to not build in its current form: 1. The TRACEPOINT macro has been renamed to TRACETOOLS_TRACEPOINT. 2. The action_tutorials_interface package has been removed, since it was duplicating an action that was already available in example_interfaces. This commit fixes both of these issues. Signed-off-by: Chris Lalancette <[email protected]>
|
Thank you for the information and the fixes :) |
|
Thank you for the quick review and merge! When you get a chance, I suggest that you update https://github.com/ros2-gbp/ros_babel_fish-release/blob/9fef367eb166e9d02220007b09705edc23d2bc98/tracks.yaml#L69 to point to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS 2 Rolling has made two changes that cause this package to not build in its current form:
This commit fixes both of these issues.
This PR is currently targeted at the
jazzybranch, but I don't think we should merge it there; it will break the build on Jazzy. Instead, I suggest creating arollingbranch here, and then retargeting this PR to therollingbranch.Once this is merged and released, this should fix the failing build as seen in https://build.ros2.org/view/Rbin_rhel_el964/job/Rbin_rhel_el964__ros_babel_fish__rhel_9_x86_64__binary/10/console
@nuclearsandwich FYI