-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to processor #261
base: main
Are you sure you want to change the base?
Changes to processor #261
Conversation
): | ||
for jshift in [ | ||
"", | ||
"JMS_down", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmantill We need to add the current JMR/JMS scale factors to the processor if we want to use these right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline @cmantill I think the current approach is fine, unless you want to update it with the new numbers from the Loukas method.
HH4b/src/HH4b/postprocessing/postprocessing.py
Line 322 in 91a83cc
and apply to this function:
HH4b/src/HH4b/processors/corrections.py
Line 337 in ac8b856