-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Stdlib dependency #767
Conversation
Amazing work, thanks! I have a pain points with this patch, too many .in files. I'm wondering if we can reduce the .in files by adding a single core.v.in file that contains the ifdefs for stuff that is Coq or Corelib and exports them, and then use Do you this this would work? I may even give it a try myself, but you surely have a better gut feeling about this now that you have patched the entire code base. |
Should work, let me try |
4172be0
to
8001cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
f74d422
to
07186b8
Compare
I had troubles run things on 8.20 since the dune theory Stdlib is not there, so I added a proxy, but I guess I broke 9.0 now since the proxy does not require Stdlib in the dune file. I think you have a dune.in for that, but seems gone |
Indeed, the few stslib specifics test didn't run anymore on 8.20. I thought it wasn't that important since they are run on 9.0 and master anyway (and we'll drop 8.20 at some point), so not worth speding time on this I'd say. |
I found the trick, I'm fixing it. |
Note that if you retrieve Stdlib specific tests on 8.20, you may want to add the coq-elpi-tests-stdlib job to the 8.20 bundle in .nix/config.nix |
everything seems to work here on 8.20, I would not mind a "make" on 9.0 if you have the checkout at hand. |
make on 9.0 fails (2 failed), let me fix that |
This comment was marked as resolved.
This comment was marked as resolved.
Hum, I think you added a second copy of Bool.v.in, other than that looks perfect. |
It's not really a copy, the one in elpi.core is essentially void for >= 9.0 whereas the one in elpi_stdlib is Bool.v from Stdlib. |
This comment was marked as resolved.
This comment was marked as resolved.
Dear @Janno (and other Bluerock folks) this is a heads up that this PR is ready and will be merged soon. It makes master work before and after the "stdlib split", on Coq 8.20 and Rocq 9.0. |
To be precise, this was already the case, the novelty being that it now works on 9.0 without Stdlib. |
Co-authored-by: Enrico Tassi <[email protected]>
Co-authored-by: Enrico Tassi <[email protected]>
squashed |
And BTW thanks @gares for fixing my primitive int failure (quite ashamed that I got caught by this stupid shadowing error). |
You were quite unlucky as well ;-) |
Except for a few tests, that get their own make targets.
Everything seems to work except derive.eqb for primitive integers, I don't know why but without the last commit, derive.eqb fails for option, list,... with an error message about primitive integers.Cc @CohenCyril following mathcomp meeting this morning