Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loc after file resolution #242

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Fix loc after file resolution #242

merged 8 commits into from
Jul 11, 2024

Conversation

gares
Copy link
Contributor

@gares gares commented Jul 10, 2024

@FissoreD would you mind testing this version of Elpi? It should give (in coq-elpi) better file names in error messages

@gares gares force-pushed the fix-loc-after-file-resolution branch from 09301af to b5fae2c Compare July 10, 2024 12:32
@FissoreD
Copy link
Collaborator

Cannot find the branch:
image

@FissoreD
Copy link
Collaborator

What command should I write to get it, I did git remote update, but still not found

@gares
Copy link
Contributor Author

gares commented Jul 10, 2024

opam pin add elpi https://gihub.com/LPCIC/elpi.git#fix-loc-after-file-resolution

@gares
Copy link
Contributor Author

gares commented Jul 10, 2024

I like the approach, **** dune!

@gares
Copy link
Contributor Author

gares commented Jul 10, 2024

elpi already depends on Re, and open Re gives you a Str module.
you should remove the str dependency and just open Re where needed.

@gares gares merged commit 7db8cff into master Jul 11, 2024
8 of 9 checks passed
@gares gares deleted the fix-loc-after-file-resolution branch July 11, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants