Dev #3
Merged
Dev #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ReleaseNotes2_3.md.
Co-Authored-By: Lew Rossman <[email protected]> Co-Authored-By: Elad Salomons <[email protected]> OpenWaterAnalytics#583
This reverts commit 7e3d5e1.
This reverts commit 3ee30ce.
…ing583 fix EN_INITSETTING
Link to community.wateranalytics.org was broken
Fix link in README.md
Add additional case for `EN_STARTTIME` to the `EN_settimeparam` function.
Limit `EN_STARTTIME` parameter value to a maximum of `SECperDAY`, and return an error code if this is exceeded.
Allow start time to be set with EN_settimeparam
…es-dev Fix use-after-free in Smatrix, test_pda
Update epanet2.bas
Changes 1 line instead of 4.
Fix EN_settankdata for elevation with SI units
…articipation allowing access to incontrols() for getting information about whether a node or link participates in a simple or rule-based control.
API access to incontrols() for information about node/link controls p… No more comments so I'm merging. Thank you @jamesuber
…_feature_in_control Dev feature in control
…milar to the parameter Power of pumps
Net1.inp have 0 MinorLoss / GUI accepts values zero for MINORLOSS
…-EN_openX Add EN_openX function
Fixes bug in checking that tank min/max levels are within volume curve.
…-tank_validation_bug_fix Update validate.c
This change addresses issue OpenWaterAnalytics#769.
…jan-2024 Update release notes and remove depreciated constants
…lows update workflows to include the header files in the artifact
…-tank_overflow_fix Account for mass lost in tank overflow
Remove the unnecessary file.
Delete tests/outfile/data/enP1kAlM
…lows-rm-warnings Update workflows to use Node.js 20 due to deprecation of Node.js 16
…-for-macos-build Create macos.yml workflow.
Fixes false negative when checking if a tank's min/max levels fall within its volume curve (see issue OpenWaterAnalytics#767 ).
…-tank_validation_fix Update validate.c
Update old build script with validate.c file
…-conan-build Fixes conan build, adds documentation for this option
Retry builds
…cript Update old build script
fix badge macos link. Thank you @Mariosmsk!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.