Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/401/use qp #534

Closed
wants to merge 16 commits into from
Closed

Issue/401/use qp #534

wants to merge 16 commits into from

Conversation

m-aguena
Copy link
Collaborator

@m-aguena m-aguena commented Aug 5, 2022

Use qp!

@coveralls
Copy link

coveralls commented Aug 5, 2022

Coverage Status

coverage: 99.777% (-0.2%) from 100.0%
when pulling d19a403 on issue/401/use_qp
into e788037 on main.

"axes[0].scatter(qp_integ, pz_integ, s=2)\n",
"axes[0].plot([0, 1], c='r', ls='--')\n",
"\n",
"axes[1].scatter(qp_integ, (pz_integ/qp_integ-1)*100, s=2)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is ValueError: x and y must be the same size from this line

@m-aguena m-aguena added HasDependency Depends on another issue to be done and removed HasDependency Depends on another issue to be done labels Jan 23, 2023
@combet
Copy link
Collaborator

combet commented Sep 11, 2023

Hi @aguena - There is an open PR in TXPipe to switch photoz information to QP. Given that we are now using CLMM inside TXPipe to compute the shear profiles, I guess we will need that functionality available in CLMM as well. So I was wondering the status of this PR?

@m-aguena
Copy link
Collaborator Author

@combet qp has been implemented here, it just waiting for PR #596 to be updated.

@m-aguena m-aguena closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add p(z) to GalaxyCluster object
4 participants