Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for new CCL release #620

Merged
merged 32 commits into from
Jun 20, 2024
Merged

Conversation

hsinfan1996
Copy link
Collaborator

@hsinfan1996 hsinfan1996 commented Mar 5, 2024

Fix how max supported CCL version is checked to prepare for the new release.

@hsinfan1996 hsinfan1996 linked an issue Mar 5, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Mar 5, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 3a5f3aa on issue/619/Fix_CCL_version_checking
into 50876a8 on main.

@hsinfan1996
Copy link
Collaborator Author

hsinfan1996 commented Mar 5, 2024

Note: origin of this issue parse("3") is identical to parse("3.0.0").

@hsinfan1996
Copy link
Collaborator Author

hsinfan1996 commented Mar 9, 2024

pyccl 3.0.1 and 3.0.2 are released.

@joezuntz
Copy link

Is there a reason you're installing CCL from source? It is available in conda-forge, and much quicker to install that way!

@hsinfan1996
Copy link
Collaborator Author

Is there a reason you're installing CCL from source? It is available in conda-forge, and much quicker to install that way!

I think it is partly because we want to check the dev versions, and in the CI script, we don't need to specify what version to install.

@hsinfan1996
Copy link
Collaborator Author

hsinfan1996 commented Jun 19, 2024

conda will be broken after installing cmake due to an upstream issue libarchive/libarchive#1976, so I moved up the installation of sphinx prereqs.

@combet
Copy link
Collaborator

combet commented Jun 20, 2024

@hsinfan1996, @m-aguena - I see this morning that you've made further changes here that should work for all CCL v3.x.x, right? Thank you! Is this ready for review/to be merged?

@hsinfan1996
Copy link
Collaborator Author

@combet Yes, this is ready for review.

@combet combet self-requested a review June 20, 2024 13:01
Copy link
Collaborator

@combet combet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All looks good and it installed and ran happily at my end with a conda installed CCL v3.0.2.

@m-aguena m-aguena merged commit 714b92d into main Jun 20, 2024
2 checks passed
@hsinfan1996 hsinfan1996 deleted the issue/619/Fix_CCL_version_checking branch June 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mechanism for checking supported CCL version
5 participants