Estimation syntax consistency

[aimalz]

Apologies, I seem to have failed to make the PR for this one when I made the others in the omnibus rail.estimation renaming. Note that the checks were failing before work on this began due to a thing that will be fixed by #7.

[aimalz]

@sschmidt23 I could use some help fixing the bug that's causing the tests to fail. I don't think it's related to the changes from this PR, but it would be good to merge this before LSSTDESC/rail#73 goes through. (Also tagging @OliviaLynn for completeness.)

[sschmidt23]

I think it's because hdf5_groupname was added to SHARED_PARAMS with a default value of "photometry", so it gets assigned now even if not specified, which was not the case when the original test was written.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2adcd9) 100.00% compared to head (08fd581) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          147       147           
=========================================
  Hits           147       147           

Flag	Coverage Δ
unittests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/rail/estimation/algos/cmnn.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sschmidt23]

fixed now, approved

[eacharles]

closed with #9

[aimalz]

Thanks again @sschmidt23 for taking care of this while I was out!