Issue 53306: Some LKS forms don't distinguish between fields properly #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-nicka
approved these changes
Jul 14, 2025
| @@ -144,9 +145,9 @@ private void reImportData(Map<String, WellRole[]> wellRoleMap) | |||
| goToTestAssayHome(); | |||
| click(Locator.linkContainingText(MULTIPLE_CURVE_ASSAY_RUN_NAME)); | |||
| clickButtonContainingText("Re-import run"); | |||
| checkCheckbox(Locator.radioButtonByNameAndValue("participantVisitResolver", "SampleInfo")); | |||
| checkCheckbox(Locator.radioButtonByNameAndValue("ParticipantVisitResolver", "SampleInfo")); | |||
There was a problem hiding this comment.
nit: I'm sure you already considered it but "ParticipantVisitResolver" seems like it'd be a good constant as well.
There was a problem hiding this comment.
I initially just pulled out constants for Locators. I did another pass and did simple strings for ParticipantVisitResolver, ThawListType, and TargetStudy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some
<input>fields are usingnameattributes that don't differentiate from similarly named fields.Related Pull Requests
Changes