Skip to content

File path related issue bundle #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
+17 −5
Open

File path related issue bundle #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40374a1
Invalid file (that exist but isn't accessible) should show red triang…
XingY Jul 15, 2025
3c0f54f
File path related bugs
XingY Jul 15, 2025
6a7e4ad
Merge branch 'develop' into fb_filePathIssues
XingY Jul 21, 2025
92aa5d7
Merge branch 'develop' into fb_filePathIssues
XingY Jul 23, 2025
68c024b
Merge branch 'develop' into fb_filePathIssues
XingY Jul 23, 2025
cb31ea0
Merge branch 'develop' into fb_filePathIssues
XingY Jul 25, 2025
8f1f336
Merge branch 'develop' into fb_filePathIssues
XingY Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "6.56.3",
"version": "6.56.4-fb-filePathIssues.1",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down
5 changes: 5 additions & 0 deletions packages/components/releaseNotes/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# @labkey/components
Components, models, actions, and utility functions for LabKey applications and pages

### version 6.X
*Released*: X July 2025
- File handling - File path related issue bundle
- Invalid file (that exist but isn't accessible) should show red triangle icon

### version 6.56.3
*Released*: 24 July 2025
- Address Issue 53366 by not putting `undefined` into `List<ValueDescriptor>`
Expand Down
7 changes: 7 additions & 0 deletions packages/components/src/internal/renderers/FileColumnRenderer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ describe('getAttachmentCardProp', () => {
iconFontCls: 'fa fa-file-image-o',
unavailable: false,
});
const dataUnavailable = { url: 'testurl', value: 'test.png (unavailable)' };
validate(getAttachmentCardProp(dataUnavailable), true, 'attachment', false, 'testurl', {
name: 'test.png',
title: 'test.png',
iconFontCls: 'fa fa-exclamation-triangle',
unavailable: true,
});
});

test('allowRemove', () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/internal/renderers/FileColumnRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ export const getAttachmentCardProp = (
if (Iterable.isIterable(data)) {
url = data.get('url');
value = data.get('value');
display = getFileDisplayValue(data.get('displayValue'));
display = getFileDisplayValue(data.get('displayValue') ?? value);
} else {
url = caseInsensitive(data, 'url');
value = caseInsensitive(data, 'value');
display = getFileDisplayValue(caseInsensitive(data, 'displayValue'));
display = getFileDisplayValue(caseInsensitive(data, 'displayValue') ?? value);
}
const titleStyle = isConditionalFormattingEnabled() ? getDataStyling(data) : undefined;
const filename = display.filename;
Expand Down