ExpObjectDataIterator: consolidate iterator logic #6788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-susanh
approved these changes
Jun 24, 2025
experiment/src/org/labkey/experiment/api/SampleTypeUpdateServiceDI.java
Outdated
Show resolved
Hide resolved
labkey-nicka
force-pushed
the
fb_alias_merge
branch
from
6c62e5d to
e694ba8
Compare
labkey-nicka
changed the title
labkey-susanh
requested changes
Jul 3, 2025
labkey-nicka
force-pushed
the
fb_alias_merge
branch
from
34508ea to
a05aff9
Compare
labkey-susanh
approved these changes
Jul 8, 2025
experiment/src/org/labkey/experiment/api/SampleTypeUpdateServiceDI.java
Outdated
Show resolved
Hide resolved
labkey-nicka
force-pushed
the
fb_alias_merge
branch
from
a05aff9 to
be7bb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This is the remanent refactor of prior work done to address Issue 53153.
Related Pull Requests
Changes
ExpDataTypeDataIteratorto encapsulate logic for data iterators that operate on experiment materials and data.FlagDataIteratorlogic to not rely on presence oflsidcolumn