Skip to content

Issue 53586: Domain field with long name can result in "PropertyURI cannot exceed 300 characters, but was 302 characters long." #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

cnathe
Copy link
Contributor

@cnathe cnathe commented Aug 18, 2025

Rationale

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53586

Several places in the code generated PropertyURIs for a domain field by appending the encoded field name to the domain type URI prefix. This can create long PropertyURI values that exceed our 300 char limit. This PR updates the DomainUtil.createUniquePropertyURI() helper to replace the "encode field name" with a Lsid DB seq as we've moved towards for other URI related cases recently.

Related Pull Requests

Changes

  • Update DomainUtil.createUniquePropertyURI() to use LsidManager.getLsidPrefixDbSeq()
  • Use DomainUtil.createUniquePropertyURI() in several places instead of appending encoded field name

@cnathe cnathe self-assigned this Aug 18, 2025
Copy link
Contributor

@labkey-klum labkey-klum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down and ran with it locally. I'd be fine relying on the automated tests over a manual test pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants