Skip to content

Fix error importing PySide 1.2.2 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix error importing PySide 1.2.2 #47

wants to merge 1 commit into from

Conversation

iromero91
Copy link

PySide 1.2.2 (at least) doesn't have a __version__ attribute in PySide.QtSvg. Slightly changing the order of imports solves the issue (though if you ask me this code is fairly smelly, there has to be a better solution.)

@hgrecco
Copy link
Contributor

hgrecco commented Feb 23, 2015

Thanks. Yes, this was taken from the IPython project to get PySide and PyQt compatibility. I will take alook. By the why, is PySide alive or it has been abandoned?

@enkore
Copy link

enkore commented Feb 23, 2015

By the why, is PySide alive or it has been abandoned?

Still no Qt 5 version in sight afaik...

@iromero91
Copy link
Author

I don't really care much about PyQt because it's not LGPL/BSD compatible.

@enkore
Copy link

enkore commented Feb 23, 2015

I don't really care much about PyQt because it's not LGPL/BSD compatible.

Not true.

http://www.riverbankcomputing.com/pipermail/pyqt/2014-February/033848.html

Phil Thompson phil at riverbankcomputing.com:

No, but thats not an ideological change. What (GPL incompatible)
license do you want use?

I contribute to several projects that use different licenses. Im
primarily concerned with the BSD and LGPL, but also Python and MIT.

As far as I am aware all of those are compatible with the GPL and so do
not need an exception.

(emphasis mine)

@hgrecco
Copy link
Contributor

hgrecco commented Feb 23, 2015

I do my best to support both PySide and PyQt. So I will be happy to merge any changes that makes this possible.

@iromero91
Copy link
Author

Thanks! this fix does work for me, but it might need more work down the line to do something saner.

@hgrecco
Copy link
Contributor

hgrecco commented Feb 23, 2015

But I wonder if the #48 is also due to a difference with PySide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants