-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #12
Open
LaDuquesaDev
wants to merge
59
commits into
Laboratoria:main
Choose a base branch
from
LaDuquesaDev:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completar templates register y login, instalar firebase auth y pendie…
…es de form, comentamos firebase
Agregamos estilos css a hero y vamos en sign up y login faltan detall…
Responsive
…ebase auth y firestore
…, falta agregar las acciones a los botones
…nicia evento en register.js de la constante formRegister con el evento Submit, hay un error ya que no lo lee y controler.js lo routea a /#
…do por el error anteriormente descrito
… evento al boton btn-register y un console, pero se esta reiniciando el controlador a la vista de inicio, agregamos window.location.hash a los eventos para que nos genere la ruta en el navegador
Eliminamos firebase.js, lo dividimos en funcionalidades. Agregamos un…
…ta firebase, funciona el evento con el console log en el evento de Registrar Cuenta en registro.js
cambios de colores en bar y textos
…o si al llamar la funcion de registerUser en register.js
No hay problemas de inicializacion de firebase al abrir la pagina per…
…e configuración en package.json para los test
…o la promesa de register, funciona register user
…top, se modifico estructura de template de register, se debe hacer el mismo cambio en login
…ntes y diagramacion
Mejoras en responsive y en CSS grid para vista hero y register, ya quedó la parte visual lista de mobile
Se deja listo el css para register y login mobile first
Responsive
…realizadas por paola
implementación de mediaQuery para vista de escritorio
Algunos cambios extra
Creo rama para testear
Sebas resuelve el error porfiiiin
…ente junto a mariano
Nueva rama master para respaldar proyecto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.