Add Windows support #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds windows support. This is done through using the time module for timing, as the time command on windows is to set time. Also the path of the test to execute is joined through os.path.join to ensure the proper separator. As bin bash is not available on windows, shell mode for subprocess was disabled. This should not be an issue as the command runs an executable either way.
|
An autoformatter ran on this in my editor. If it is a problem I can undo those changes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds windows support. This is done through using the time module for timing, as the time command on windows is to set time. Also the path of the test to execute is joined through os.path.join to ensure the proper separator. As bin bash is not available on windows, shell mode for subprocess was disabled. This should not be an issue as the command runs an executable either way.