Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noindex tag #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add noindex tag #67

wants to merge 1 commit into from

Conversation

zuccs
Copy link

@zuccs zuccs commented Aug 3, 2024

add tag to pages that shouldn't show in search

add tag to pages that shouldn't show in search
@@ -4,6 +4,7 @@ author: Andreas Kling
description: Place holder.
image: /assets/img/plant.webp
type: Hidden
noindex: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't getting propagated through to the header file. But also, this may not be needed, as you could just hide the index based on the type and do noindex if it's type: Hidden. Either way, it somehow needs to get passed to the header on the posts page.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

I did consider reusing Hidden for that, but I thought there might be pages you want hidden from menus, but still indexed in search.

I also noticed you can access https://ladybird.org/newsletter/2024-07-31/ but they are not indexed - do you want them to be?

Copy link
Contributor

@versecafe versecafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually do anything since noindex isn't passed up to the header component and is therefor always undefined and as such the tag is never included, eithe pass it up through Post.astro -> Head.astro or handle index policies in robots.txt for broader rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants