Fix the Ender Dragon spamming screen shakes #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyrofab
reviewed
Apr 6, 2024
src/main/java/org/ladysnake/effective/mixin/screenshake/EnderDragonRoarScreenshakeAdder.java
Outdated
Show resolved
Hide resolved
|
Also could you update the gradle wrapper while you are at it ? |
What I'd actually try is an |
|
I actually personally liked the screenshake spamming and left it intentionally cause it was really intense :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with ender dragon's screen shakes is that uh, while Vanilla spamming sounds ends only being a bit annoying, Effective spamming screen shakes can make someone a bit sick! especially since it pretty much makes the config option pretty much useless by only relying on LodestoneLib's cap!
This makes the ender dragon roar only happen once, while it attempts to make that single roar count; as a side-effect, however, it isn't as exaggerated as the other roars, but since it's now relatively normal? the ender dragon roar can now be tuned with the same config option as everybody else with nothing feeling off at all; I encourage testing this new roar for the feeling though, because it is something I wanna nail too