lightningd: log if builtin plugin fails to start

Lightningd should log if a builtin plugin fails to start instead of silently skip over it. Changelog-Add: log message if builtin plugin fails to start. Signed-off-by: Lagrang3 <[email protected]>
Lagrang3 · Sep 10, 2024 · 2bd9c22 · 2bd9c22
1 parent 78b9ccf
commit 2bd9c22
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/lightningd/plugin.c b/lightningd/plugin.c
@@ -2536,14 +2536,19 @@ void plugins_set_builtin_plugins_dir(struct plugins *plugins,
 				     const char *dir)
 {
 	/*~ Load the builtin plugins as important.  */
-	for (size_t i = 0; list_of_builtin_plugins[i]; ++i)
-		plugin_register(plugins,
-				take(path_join(NULL, dir,
-					       list_of_builtin_plugins[i])),
-				NULL,
-				/* important = */
-				!streq(list_of_builtin_plugins[i], "cln-renepay"),
-				NULL, NULL);
+	for (size_t i = 0; list_of_builtin_plugins[i]; ++i) {
+		struct plugin *p = plugin_register(
+		    plugins,
+		    take(path_join(NULL, dir, list_of_builtin_plugins[i])),
+		    NULL,
+		    /* important = */
+		    !streq(list_of_builtin_plugins[i], "cln-renepay"), NULL,
+		    NULL);
+		if (!p)
+			log_unusual(
+			    plugins->log, "failed to register plugin %s",
+			    path_join(tmpctx, dir, list_of_builtin_plugins[i]));
+	}
 }
 
 void shutdown_plugins(struct lightningd *ld)