Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement MPT part of generic extraction (Part 1) #385

Open
wants to merge 180 commits into
base: main
Choose a base branch
from

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Oct 4, 2024

Related issue https://github.com/Lagrange-Labs/zkmr-tracking/issues/265

Design document MPT Extraction

Summary

  • Add the new ColumnGadget and MetadataGadget.
  • Update the leaf circuits of single and mapping variables, and add a new leaf circuit for mapping of mappings.
  • Update the integration test to make the values extraction work for the single and mapping variables (the rows digest check is failed, will update in a further PR).

@silathdiir silathdiir changed the title feat: implement MPT part of generic extraction feat: implement MPT part of generic extraction (Part 1) Oct 23, 2024
Copy link
Contributor

@nicholas-mainardi nicholas-mainardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This PR introduces a circuit to expose the results of simple `SELECT`
queries without aggregation functions, avoiding the need to build a
results tree.
Base automatically changed from feat/unproven-limit-offset-queries to feat/tabular-queries October 29, 2024 21:06
Base automatically changed from feat/tabular-queries to main November 13, 2024 16:08
@delehef delehef force-pushed the main branch 8 times, most recently from d8cf76a to a9e2b59 Compare January 25, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants