Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest] Move The Tenshodo Showdown mob code #6196

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

jamesbradleym
Copy link
Contributor

@jamesbradleym jamesbradleym commented Aug 31, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds onSteal to IF
Moves npc code handling onSteal for the THF AF1 quest into the quest lua

Steps to test these changes

Steal from Quadavs during THF AF1 quest, see unchanged results.

Notes

Some players indicated they could steal the stew prior to flagging the quest:
1
2

@jamesbradleym jamesbradleym changed the title move mob code into quest lua [Quest] Move The Tenshodo Showdown mob code Aug 31, 2024
@claywar
Copy link
Contributor

claywar commented Aug 31, 2024

onSteal is not currently observed by Interaction.

@jamesbradleym
Copy link
Contributor Author

onSteal is not currently observed by Interaction.

I swear when I tested I got the stew item but now I'm not getting it..

@jamesbradleym jamesbradleym changed the title [Quest] Move The Tenshodo Showdown mob code [CPP/Quest] Add onSteal to IF + Move The Tenshodo Showdown mob code Aug 31, 2024
@jamesbradleym jamesbradleym force-pushed the The-Tenshodo-Showdown branch 3 times, most recently from b76deab to 24bfa48 Compare August 31, 2024 18:02
@jamesbradleym jamesbradleym marked this pull request as draft August 31, 2024 18:02
@jamesbradleym jamesbradleym changed the title [CPP/Quest] Add onSteal to IF + Move The Tenshodo Showdown mob code [Quest] Move The Tenshodo Showdown mob code Aug 31, 2024
@jamesbradleym jamesbradleym marked this pull request as ready for review August 31, 2024 18:09
@jamesbradleym
Copy link
Contributor Author

@claywar Looks like it worked because the stew is already in the mob_droplist steal section, this makes the whole onSteal escapade unnecessary?

@claywar
Copy link
Contributor

claywar commented Aug 31, 2024

The way to verify this is to see if quadav stew can be stolen by people not on the quest (I'm betting this is no).

@jamesbradleym jamesbradleym marked this pull request as draft August 31, 2024 18:12
@jamesbradleym
Copy link
Contributor Author

jamesbradleym commented Aug 31, 2024

Ah, and in that case it would need to be removed from the drop list + onSteal implemented for IF. 👍🏻

@jamesbradleym
Copy link
Contributor Author

As a note: Yes you can steal the stew prior to quest start, but stew seems to be prioritized for those currently on the quest per player reports on wikis

@jamesbradleym
Copy link
Contributor Author

@claywar I've made the necessary updates for onSteal to be recognized in IF, would you mind taking a look to make sure this is following the right pattern? Took a look at how onTrigger and onTrade operate in IF to put together onSteal so hopefully it's clear cut.

Tested with the quest and on successful steal the onSteal in the quest lua is called and returns the Quadav Stew to be given to the player

@jamesbradleym jamesbradleym marked this pull request as ready for review September 10, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants