[BCNM] Implement BCNM20 Shooting Fish #6220
Open
+67
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Aerec
force-pushed
the
ShootingFish
branch
5 times, most recently
from
e5842f7
to
8fdb08d
Compare
Frankie-hz
reviewed
Sep 6, 2024
sql/mob_skill_lists.sql
Outdated
| -- Next available ID: 2014 | ||
| INSERT INTO `mob_skill_lists` VALUES ('Shooting_Fish',2014,313); -- knockback aquaball - BCNM20 Shooting Fish | ||
|
|
||
| -- Next available ID: 2008 |
There was a problem hiding this comment.
Can remove this, 2008 is used
The-Aerec
force-pushed
the
ShootingFish
branch
from
8fdb08d
to
97ade5e
Compare
jmcmorris
approved these changes
Sep 7, 2024
| ----------------------------------- | ||
| require('scripts/globals/mobskills') | ||
| ----------------------------------- | ||
| local mobskillObject = {} |
Co-Authored-By: dallano <[email protected]>
The-Aerec
force-pushed
the
ShootingFish
branch
from
97ade5e
to
085858e
Compare
|
I can't comment on the exact line, but is everything in place for this to not be considered experimental? Mob levels, mob hp, resistances, the mechanics, the loot, the entry, etc. |
|
The loot in the .lua is set to the exact rates of Clopedia with limited samples. Given the limited drop variance, Platoon weapons for example are more likely each an equal weight with the others in the slot. Would it make sense for the weights to be more equalized for some of these drops? |
|
Yes, ideally we use loot with the weights defined in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Implements the Aqua Ball Mechanic for BCNM20 shooting fish.
Basis and evidence for following changes:
https://youtu.be/V0Qp99O1AkA
https://drive.google.com/open?id=1ZpZ9FEQ3TYeCc9lPig-y2p6pCRLNkdyF
https://ffxiclopedia.fandom.com/wiki/Shooting_Fish
Ability 313 it is - renamed from counterspore for clarity
Steps to test these changes
Enter BCNM20 shooting fish and see the mobs properly only use their knockback aquaball as a auto-attack.