Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest][lua][sql] The Die is Cast #6932

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

KnowOne134
Copy link
Contributor

@KnowOne134 KnowOne134 commented Feb 3, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

adds quest The Die is Cast
adds Random Ring

https://ffxiclopedia.fandom.com/wiki/The_Die_Is_Cast
https://youtu.be/b7b5ABOi1n4

Steps to test these changes

follow wiki steps
-- Ratihb: !pos 75.225 -6.000 -137.203 50
-- Ekhu Pesshyadha: !pos -13.043 0.999 103.423 50
-- Jijiroon: !pos 15.913 0.000 -32.676 53
-- qm9: !pos 311.088 -3.674 170.124 54

@KnowOne134 KnowOne134 changed the title [Quest][lua] The Die is Cast [Quest][lua][sql] The Die is Cast Feb 3, 2025
mob:setMagicCastingEnabled(false)
mob:setMobSkillAttack(788)
end
end)
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the CI:

mob:addListener('COMBAT_TICK', 'BUKKI_TICK', function(mobArg)
    if mobArg:getHPP() <= mobArg:getLocalVar('tp_spam') and mobArg:getLocalVar('tp_spam') > 0 then
        mobArg:setLocalVar('tp_spam', 0)
        mobArg:setMagicCastingEnabled(false)
        mobArg:setMobSkillAttack(788)
    end
end)

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Athough, you could always just use the regular entity function for combat tick, i would think

entity.onMobFight = function(mob, target)
    -- Logic
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks, couldnt figure out what it wanted, we dont have to use args


['Bukki'] =
{
onMobDeath = function(mob, player, isKiller, noKiller)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onMobDeath = function(mob, player, optParams)

We now use optParams.isKiller and opt.Params.noKiller. So those 2 are part of the optParams tsable

@claywar claywar merged commit b9d52ab into LandSandBoat:base Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants